Ensure queues are bound with durable: true option#3604
Merged
Conversation
Modern versions of RabbitMQ do not allow queues that are not durable and not exclusive. This change ensures that the queues we define are now all durable to fix this issue. We also ensure we only create each queue once and then bind two exchanges
stringiest
approved these changes
Apr 28, 2026
Contributor
stringiest
left a comment
stringiest
left a comment
There was a problem hiding this comment.
This looks great, thanks!
Adding a link to the RabbitMQ docs re durability for future reference.
|
|
||
| # messages on the {queue}_discarded_dlx are routed back to the original queue | ||
| channel.queue(name).bind(discarded_dlx) | ||
| channel.queue(name, durable: true, arguments: { "x-dead-letter-exchange" => retry_dlx.name }).tap do |q| |
Contributor
There was a problem hiding this comment.
Oooh I haven't come across tap before! It's very pleasing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern versions of RabbitMQ do not allow queues that are not durable and not exclusive. This change ensures that the queues we define are now all durable to fix this issue.
We also ensure we only create each queue once and then bind two exchanges
This fixes an error when make-ing the search-api in govuk-docker